D18369: Create tel: links for phone numbers

Sune Vuorela noreply at phabricator.kde.org
Sun Jan 20 19:04:26 GMT 2019


svuorela added inline comments.

INLINE COMMENTS

> ktexttohtml.cpp:159
> +    // this isn't 100% accurate, we filter stuff below that is too hard to capture with a regexp
> +    static const QRegularExpression telPattern(QStringLiteral(R"([+0](( |( ?[/-] ?)?)\(?\d+\)?+){6,30})"));
> +    const auto match = telPattern.match(mText, mPos, QRegularExpression::NormalMatch, QRegularExpression::AnchoredMatchOption);

How are the thread safety of the KTextToHTML functions?

And does that match the thread safety of the QRegularExpression and the const methods in there?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D18369

To: vkrause
Cc: svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190120/645765c9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list