D18384: Allow creating directory named '~' and throw a warning before creating it.

[Pino Toscano]

pino added a comment.


  In D18384#396895 <https://phabricator.kde.org/D18384#396895>, @shubham wrote:
  
  > @pino got it what you meant.
  
  
  Definitely not. Let me explain it again:
  
  - so far, KNewFileMenuPrivate::confirmCreatingHiddenDir is used only to ask to the user whether choice of a directory starting with '.' is wanted; KNewFileMenuPrivate::confirmCreatingHiddenDir checks whether ask by using the message box "do not ask again" key "confirm_create_hidden_tilde_dir"
  - a user tries to create a directory starting with '.':
    1. they get the messagebox that confirmCreatingHiddenDir shows
    2. they tick the "do not ask again"
    3. they proceed
  - as result of the point above, the key "confirm_create_hidden_tilde_dir" is set
  - your changes rename KNewFileMenuPrivate::confirmCreatingHiddenDir to confirmCreatingDir, and make it used also when a directory starts with '~'
  - the same user tries to create a directory starting with '~':
    1. confirmCreatingDir is called
    2. the "confirm_create_hidden_tilde_dir" key is set, so no message box is shown
    3. the directory is created directly, without user confirmation

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190120/054cd2c4/attachment.html>