D18384: Allow creating directory named '~' and throw a warning before creating it.

[Pino Toscano]

pino added a comment.


  Also, not related to the code: @shubham, you seem to often remove your own comments. This is a bad practice for many POV of views (transparency, breaks the logic of a conversation, etc). As these reviews send notification emails to mailing lists usually, then your removed messages are archived, and thus removing them is useless.
  Please stop doing this anti-social practice, thank you.

INLINE COMMENTS

> knewfilemenu.cpp:408-413
> +void KNewFileMenuPrivate::confirmCreatingDir(const QString &name)
>  {
>      if (!KMessageBox::shouldBeShownContinue(QStringLiteral("confirm_create_hidden_dir"))) {
>          _k_slotCreateHiddenDirectory();
>          return;
>      }

renaming confirmCreatingHiddenDir and using it also for another case means that the "confirm_create_hidden_dir" messagebox confirmation also applies to the other cases (filename == '~' in this case)

> knewfilemenu.cpp:911
>              }
> +
>              url = baseUrl;

extra line added

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190120/2ecb1616/attachment.html>