D18125: KateStatusBar: Add dictionary button

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I played with this patch now ;)
  
  First: to now have KWrite crash on start, one need to modify one line to:
  
  if (!m_dictionaryGroup->checkedAction() || (m_dictionaryGroup->checkedAction()->data().toString() != newDict) || m_dictionary->text().isEmpty()) {
  
  m_dictionaryGroup->checkedAction() might be null.
  
  For the naming: Given we show the encodings with their short-names, too, I can live with de_DE or stuff like that.
  
  For the overhead: I would like to have this optional and disabled per default, that avoids all that work in cursorPositionChanged()
  Just like we do for word count/...

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190120/c027488e/attachment.html>