D17977: Improve reliability and semantic correctless of dupe test
Noah Davis
noreply at phabricator.kde.org
Fri Jan 18 19:02:05 GMT 2019
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.
I found an issue.
With the patch, the dupe test does not detect 2 identical files with the same name in different categories. It is able to detect that issue from
How to reproduce:
1. `cp icons/categories/32/applications-internet.svg icons/preferences/32/applications-internet.svg`
2. `make && make test`
Failed test before patch (includes false positives and true positive): F6555407: LastTest.old.log <https://phabricator.kde.org/F6555407>
Passed test after patch (no false positives or true positive): F6555406: LastTest.log <https://phabricator.kde.org/F6555406>
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D17977
To: ngraham, #breeze, ndavis, GB_2
Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190118/d8c96af2/attachment.html>
More information about the Kde-frameworks-devel
mailing list