D17122: RFC: Use wl_display_add_socket_auto by default
Fabian Vogt
noreply at phabricator.kde.org
Fri Jan 18 07:47:58 GMT 2019
fvogt added a comment.
In D17122#395537 <https://phabricator.kde.org/D17122#395537>, @romangg wrote:
> I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket.
If `socketName` is overwritten after using wl_display_add_socket_auto, it's not possible to call `start` twice without resetting `socketName` again.
> According to description some autotest fails. Which one exactly?
testSocketName as the default value of socketName changed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17122
To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190118/a5dcfcf5/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list