D18317: Don't fail if defaultLanguage dictionary can't be loaded
Ahmad Samir
noreply at phabricator.kde.org
Thu Jan 17 13:06:41 GMT 2019
ahmadsamir created this revision.
ahmadsamir added a reviewer: sandsmark.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
If the files of the the dictionary set in defaultLanguage= can't be
loaded, instead of failing silently, try to load the locale language
dictionary, and display a message informing the user of what's been done.
BUG: 325541
FIXED-IN: 5.55.0
TEST PLAN
- Edit ~/.config/KDE/Sonnet.conf (or wherever your distro puts the conf file under the home dir, and set defaultLanguage= to something invalid/unavailable, say en_AB
- Start e.g. kate and try to spell check something; note that doesn't work and this error log is spewed to the terminal: "sonnet.core: No language dictionaries for the language: "de_AT_ost""
- Apply the diff and try again
REPOSITORY
R246 Sonnet
BRANCH
invalid-defaultLanguage
REVISION DETAIL
https://phabricator.kde.org/D18317
AFFECTED FILES
src/core/CMakeLists.txt
src/core/loader.cpp
src/core/sonnet-core.pro
To: ahmadsamir, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190117/3194385d/attachment.html>
More information about the Kde-frameworks-devel
mailing list