D11235: [DrKonqi] Request change of ptrace scope from KCrash

Oswald Buddenhagen noreply at phabricator.kde.org
Wed Jan 16 16:33:59 GMT 2019


ossi added a comment.


  will also need to wait for commit message update, like the other change.

INLINE COMMENTS

> ptracer.cpp:92
> +
> +    qCWarning(DRKONQI_LOG) << "debugged process did not acknowledge setting ptracer to" << debuggerpid;
> +    close(sfd);

not wrong per se, but mildly misleading, as it suggests the problem is on the other end, which is not necessarily true, this being a catch-all. "cannot set ptracer" would cover all bases (while still not being particularly helpful).

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190116/1db4e749/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list