D18277: Add a new preferences-desktop-theme icon, rename the old one

TrickyRicky noreply at phabricator.kde.org
Tue Jan 15 20:04:39 GMT 2019


trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D18277#393868 <https://phabricator.kde.org/D18277#393868>, @ngraham wrote:
  
  > Recommendation:
  >
  > - In this patch, just create a new LnF/Global theme icon with a new name. Maybe `preferences-desktop-global-theme`?
  > - I rename `preferences-desktop-theme` to `preferences-desktop-application-theme` and put a compatibility symlink in place
  > - Over time, we port all existing users of `preferences-desktop-theme` to use `preferences-desktop-application-theme` instead
  > - Once there are no more users, we delete the compatibility symlink for `preferences-desktop-theme`
  >
  >   Thoughts?
  
  
  Sure, I just chose the naming from a suggestion in the chat. I will update the diff with the new icon called `preferences-desktop-global-theme`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190115/6aab9007/attachment.html>


More information about the Kde-frameworks-devel mailing list