D18249: [datamodel] Rework items insert/remove

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik, ngraham, mart, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  I give a try to rework insertion / deletion of items in datamodel which is used in systemtray. This continues approach from D16890 <https://phabricator.kde.org/D16890>, what the problem is
  
  1. Right click systemtray -> configure
  2. Click on Entries
  3. Click Ok
  
  Even only touching model dismissing dialog made index after invalid, now clicking on any entry in systray result in invalid index
  
  Old approach tries to make optimization but that's not a right place since QML is time-to-time rewritten itself, also it sets role names incorrect to me.

TEST PLAN
  Still not complete tested

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18249

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp

To: anthonyfieroni, davidedmundson, broulik, ngraham, mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190114/e42e9dc2/attachment.html>