D17528: Refactor SlaveInterface::calcSpeed

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fvogt wrote in slaveinterface.cpp:114
> What does this actually test for?

This results in a fast ramp up when the transfer has stalled for more than ~8 seconds, like at the begin of a transfer. Likely needs a comment.

> fvogt wrote in slaveinterface_p.h:62
> Is there any reason to use a qvector instead of a std::array/c array?
> It'll only introduce more overhead.

std::array can not be resized. At first, there is only one element.

This requirement could be avoided  around by filling the the array with {0,0} elements, which results in identical behavior.

We would also need a method for shifting the entries. (.removeFirst(), append()).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure, fvogt
Cc: fvogt, davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190114/e963d0a1/attachment.html>