D18205: test empty and zero gps data

Alexander Stippich noreply at phabricator.kde.org
Sun Jan 13 11:23:20 GMT 2019


astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractortest.cpp:65
> although only copied, I think it should be written like the other two:
> `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);`

That's not possible, qFuzzyCompare does not handle this correctly with a too small epsilon. It's probably because of the float->double conversion in the extractor

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18205

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190113/40825846/attachment.html>


More information about the Kde-frameworks-devel mailing list