D18205: test empty and zero gps data
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Jan 12 16:46:22 GMT 2019
bruns added inline comments.
INLINE COMMENTS
> exiv2extractortest.cpp:62
> +
> + using namespace KFileMetaData::Property;
> + QCOMPARE(result.properties().value(PhotoGpsLatitude).toDouble(), 41.411);
move this up, as it is not specific to this test case
> exiv2extractortest.cpp:65
> + QCOMPARE(result.properties().value(PhotoGpsLongitude).toDouble(), 2.173);
> + QVERIFY(qAbs(result.properties().value(PhotoGpsAltitude).toDouble() - 12.2) < 0.0001);
> +
although only copied, I think it should be written like the other two:
`QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);`
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18205
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190112/d7b680eb/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list