D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

Anthony Fieroni noreply at phabricator.kde.org
Sat Jan 12 13:02:04 GMT 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kcheckaccelerators.cpp:87
> +    static bool doCheckAccelerators = true;
> +
>      QCoreApplication *app = QCoreApplication::instance();

We can cheet here

  if (!doCheckAccelerators) {
      return;
  }

> kcheckaccelerators.cpp:114
> +
> +    if (doCheckAccelerators) {
> +        KCheckAcceleratorsInitializer *initializer = new KCheckAcceleratorsInitializer(app);

Don't need check :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D18204

To: aacid
Cc: davidedmundson, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190112/866b1628/attachment.html>


More information about the Kde-frameworks-devel mailing list