D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui
Anthony Fieroni
noreply at phabricator.kde.org
Sat Jan 12 05:24:15 GMT 2019
anthonyfieroni added inline comments.
INLINE COMMENTS
> kcheckaccelerators.cpp:97
> +
> + if (!app->eventDispatcher()) {
> + // We are called with event dispatcher being null when KXmlGui is being loaded
That's static member, you don't need instance. BTW can we check only for null app, i mean if it's not directly linked library qapp will be null, it's not checked.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D18204
To: aacid
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190112/f4c90aff/attachment.html>
More information about the Kde-frameworks-devel
mailing list