D10716: handle wrong password when using sudo which asks for another password
Jonathan Riddell
noreply at phabricator.kde.org
Fri Jan 11 14:44:06 GMT 2019
jriddell marked an inline comment as done.
jriddell added a comment.
> Is it necessary to write the mock su/sudo in python? That introduces a big and mostly unnecessary dependency on python.
Nope but that's what was easiest for me and I'm out of energy for this
> By adding a new constructor to SuCommand which allows to specify the full path to su/sudo, testing would be much easier. It might be usable outside of the tests as well.
I looked at that but I'd be scared of introducing binary incompatiblity. This approach covers the current needs.
> The testcases would be simpler if it used QTESTDATA and rows for the su/sudo and correct/incorrect password cases
Something else I need to learn about.
REPOSITORY
R299 KDESu
REVISION DETAIL
https://phabricator.kde.org/D10716
To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190111/249d9baa/attachment.html>
More information about the Kde-frameworks-devel
mailing list