D18178: fix environment setup of klanguagename test
Harald Sitter
noreply at phabricator.kde.org
Fri Jan 11 10:27:16 GMT 2019
sitter created this revision.
sitter added reviewers: aacid, rikmills.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
- use correct env vars LANG and LANGUAGE
- as an additional safety-net explicitly set QLocale default to english
(the latter kinda overrides the former, but better save than sorry since it
has no adverse effects to do both)
this should make tests pass regardless of potentially weird env states some
CIs may have
TEST PLAN
test passes on kubuntu ci. my theory is that QLocale picked the default before the env was set up and therefore used `C` instead of `en` thus bypassing the en=>en_US coercion
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18178
AFFECTED FILES
autotests/klanguagenametest.cpp
To: sitter, aacid, rikmills
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190111/18ef5e46/attachment.html>
More information about the Kde-frameworks-devel
mailing list