D18164: Review KateGotoBar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedialogs.cpp:1130
> +        // and with my mousepad was the experience also flawlessly
> +        if (delta > 100) {
> +            delta = 0;

https://doc.qt.io/qt-5/qwheelevent.html#angleDelta
It should be 120, also you can have 2 separate delta members

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190110/2aec22a7/attachment-0001.html>