D17528: Refactor SlaveInterface::calcSpeed

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  We're getting some `SIGFPE` crash reports in this area: Bug 402665
  I failed to reproduce them, though. Best is probably to revert this patch because Frameworks release is imminent.

INLINE COMMENTS

> slaveinterface.cpp:113
> +        const SlaveInterfacePrivate::TransferInfo last = {elapsed_time, (d->filesize - d->offset)};
> +        KIO::filesize_t lspeed = 1000 * (last.size - first.size) / (last.time - first.time);
>          if (!lspeed) {

We likely get a division by zero here for some reason

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: broulik, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190110/b69aa83c/attachment-0001.html>