D10446: Add KLanguageName

Harald Sitter noreply at phabricator.kde.org
Wed Jan 9 15:15:00 GMT 2019


sitter added inline comments.

INLINE COMMENTS

> aacid wrote in klanguagenametest.cpp:80
> Do you think it makes sense adding this?
> 
>   void testNoString()
>   {
>       // Qt doesn't have za support so no string at all
>       QCOMPARE(KLanguageName::nameForCode("za"), QString());
>   }

👍 I'll add it

> aacid wrote in klanguagename.h:34
> Needs to be 5.55 i think

Going to update

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D10446

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190109/552181a8/attachment.html>


More information about the Kde-frameworks-devel mailing list