D18089: KLauncher: handle process dying with exitStatus 0

[Ahmad Samir]

ahmadsamir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When a process dies with exitStatus 0, it could well be the app exited
  cleanly, and there's no need to display an error message.
  
  For example starting kate from a widget on the panel/desktop, where it
  shows the session chooser dialog before ever entering the main app event
  loop, then quitting/closing the dialog without starting kate. In a case
  like that matchesPendingRequest() will always return false as the service
  name hasn't (and won't) been changed from the unique x.xxx to org.kde.kate.
  
  BUG: 389678
  FIXED-IN: 5.55.0

TEST PLAN
  Before applying the diff:
  
  - set kate to "manually choose a session" on startup and add a kate widget to the desktop/panel and start kate from that widget
  - in the session chooser dialog, select quit (or close in newer versions)
  - an error message is displayed "KDEInit could not launch /usr/bin/kate"

REPOSITORY
  R303 KInit

BRANCH
  klauncher-kateSessionManager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18089

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: ahmadsamir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190108/a2e528c7/attachment.html>