D18038: Fix semantics for ghns_exclude
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Mon Jan 7 13:30:28 GMT 2019
leinir created this revision.
leinir added reviewers: ronaldv, KDE Store.
leinir added projects: KNewStuff, KDE Store.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
After much discussion on the topic, it came to light that the specific grammar used for the default tag in KNSCore was incorrect, as it was an action verb (rather than an adjective the way the metadata tags are supposed to be). While this does mean that previous versions of Frameworks will not have the filtering functionality by default, it is otherwise non-invasive and causes no side effects apart from the server-suggested filtering working.
CCBUG: https://bugs.kde.org/show_bug.cgi?id=402888
TEST PLAN
Run the test tool without this patch: Items which are supposed to be excluded are not excluded
Run the test tool with this patch: Items which are supposed to be excluded from listings are excluded.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D18038
AFFECTED FILES
autotests/knewstuffentrytest.cpp
src/core/engine.cpp
src/core/engine.h
src/core/tagsfilterchecker.cpp
src/core/tagsfilterchecker.h
tests/testdata/entry.xml
To: leinir, ronaldv, #kde_store
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190107/60bdedd0/attachment.html>
More information about the Kde-frameworks-devel
mailing list