D17973: [Android] Fail more gracefully when building with API < 23
Nicolas Fella
noreply at phabricator.kde.org
Fri Jan 4 23:53:18 GMT 2019
nicolasfella created this revision.
nicolasfella added reviewers: vkrause, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Building the Android backend with SDK < 23 is successful but fails at runtime because the jar is not found. Instead of just not including the jar when < 23 don't include the backend at all.
TEST PLAN
Itinerary now doesn't crash at startup
REPOSITORY
R289 KNotifications
BRANCH
grace
REVISION DETAIL
https://phabricator.kde.org/D17973
AFFECTED FILES
src/CMakeLists.txt
src/knotificationmanager.cpp
To: nicolasfella, vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190104/0f292a00/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list