D17911: Fix failing knewfilemenu test and underlying reason for its failure

[David Faure]

dfaure added a comment.


  Hmm, let me read the unittest more closely.
  
  The scenario is: "New Folder" exists. The user asks to create a new folder, the initial suggestion in the dialog is "New Folder (1)". The user removes the (1), and hits OK, i.e. the user is asking to create "New Folder" again.
  The unittest is then just checking that "New Folder" exists, which is kind of broken since it does exist anyway, since that's the initial setup.
  
  But now you're testing that "New Folder (1)" gets created? That seems really odd, it's not what the user is asking for.

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190104/7d6e1388/attachment.html>