D12336: Replace several Q_ASSERTs with proper checks

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I am very much in favour of this change.
  
  In fact, we had this discussion already a long time ago on the mailing list, namely that baloo has (had?) zero error handling and simply assuming that everything works by adding some Q_ASSERTS.
  
  @bruns You are working on this code for quite a time now. I trust you know very much what you are doing much more than possibly anyone else. I know that you would like to get a better review, but having a review open for 5+ months clearly shows we have an issue elsewhere.
  
  Please proceed and commit - I am taking the liberty to give a +2: If there are other issues, the these can still be fixed in followup commits.

REPOSITORY
  R293 Baloo

BRANCH
  db_robustness2

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, #frameworks, ngraham, poboiko, dhaumann
Cc: dhaumann, ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190228/69189f70/attachment.html>