D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:184
> +    if (savedProperties.contains("COMPOSER")) {
> +        const auto  composersString = TStringToQString(savedProperties["COMPOSER"].toString(";")).trimmed();
> +        const auto composers = contactsFromString(composersString);

doubled space

> taglibextractor.cpp:208
> +        QStringList conductors = contactsFromString(conductorString);
> +        foreach(const QString& arr, conductors) {
> +            result->add(Property::Conductor, arr);

Can you also use the same style as above, i.e. `const auto` and `for( : )`?

> taglibextractor.cpp:215
> +        QStringList arrangers = contactsFromString(arrangerString);
> +        foreach(const QString& arr, arrangers) {
> +            result->add(Property::Arranger, arr);

dito, and below ...

> taglibextractor.cpp:285
> +    /* Special handling because TagLib::PropertyMap matches "TPUB" to "LABEL"
> +     * Insert manually for Publisher */
> +    lstID3v2 = Id3Tags->frameListMap()["TPUB"];

`*/` on a separate line

> taglibextractor.cpp:300
> +       a 5 stars rating to a range of 0-255 for MP3.
> +       Match it to baloo rating with a range of 0 - 10 */
> +    lstID3v2 = Id3Tags->frameListMap()["POPM"];

`*/` on separate line, leading `*` on other lines

> taglibextractor.cpp:300
> +       a 5 stars rating to a range of 0-255 for MP3.
> +       Match it to baloo rating with a range of 0 - 10 */
> +    lstID3v2 = Id3Tags->frameListMap()["POPM"];

s/Match/Map/

> taglibextractor.cpp:330
> +       with a range of 0 to 100 (stored in steps of 10) and make it compatible
> +       with baloo rating with a range from 0 to 10 */
> +    TagLib::MP4::ItemListMap::Iterator itRating = allTags.find("rate");

dito

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190228/c7e89b3c/attachment-0001.html>