D12336: Replace several Q_ASSERTs with proper checks

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Feb 27 02:01:33 GMT 2019


bruns added a comment.


  In D12336#333853 <https://phabricator.kde.org/D12336#333853>, @apol wrote:
  
  > If it was silently corrupting the DB maybe the right solution would have been to integrate baloo properly with KCrash.
  >  Like @sitter did in https://phabricator.kde.org/D15573.
  
  
  **Silently** - it does not crash, garbage data ends up in the database for (mostly) unknown reasons.
  
  Only known reason for zero IDs are races due to renames and similar, where e.g. a file is added with some path, and the parent does not exist microseconds later (at least not under the previous name).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12336

To: bruns, #baloo, michaelh, #frameworks
Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190227/6412e076/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list