D19170: Fix crash while moving files

David Hallas noreply at phabricator.kde.org
Tue Feb 26 15:37:30 GMT 2019


hallas added inline comments.

INLINE COMMENTS

> filecopyjob.cpp:495
> +        } else if (job == d->m_chmodJob) {
> +            if (d->m_delJob) {
> +                d->m_delJob->kill(Quietly);

Should we also set d->m_chmodJob to nullptr here, just like the m_putJob handling branch?

> filecopyjob.cpp:500
> +        } else if (job == d->m_delJob) {
> +            if (d->m_chmodJob) {
> +                d->m_chmodJob->kill(Quietly);

Should we also set d->m_delJob to nullptr here, just like the m_putJob handling branch?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190226/11ee3324/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list