D18664: Baloo engine: treat every non-success code as a failure
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Thu Feb 21 19:40:36 GMT 2019
bruns added a comment.
I think this looks good now, but I would prefer an OK from another developer, as this has become quite large.
Readability good profit from `if (rc)` -> `if (rc != MDB_SUCCESS)` resp. `if (rc == 0)` -> `if (rc == MDB_SUCCESS)`, but I am not sure about this.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D18664
To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190221/e3cb856e/attachment.html>
More information about the Kde-frameworks-devel
mailing list