D19097: Add a test and document PropertyMap/VariantMap conversion

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Feb 21 19:22:22 GMT 2019


bruns added a comment.


  These two conversion functions should just be deprecated, as they are not expecially useful.
  
  `toPropertyMap` is only used (an no longer will be after D19088 <https://phabricator.kde.org/D19088>) inside baloo as a temporary for the Json conversion, and `toVariantMap` is completely unused.

INLINE COMMENTS

> properties.h:367
> + * PropertyMap is a map which stores the results as
> + * <Property::Property, QVariant> pairs
> + * obtained from the extractors.

This is wrong. **How** it is stored is internal to the map implementation, but
in general keys and values are stored independently.

The typedef itself documents everything there is to know.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19097

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190221/2d24a492/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list