D18664: Baloo engine: treat every non-success code as a failure

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Feb 21 18:06:24 GMT 2019


bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> bruns wrote in mtimedb.cpp:110
> `if  (rc != MDB_NOTFOUND)` for the message

**for the message** - you now only retrieve the first entry, spew an error message, and break. In case the key does not exist, you loop infinitely.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190221/223c4169/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list