D19170: Fix crash while moving files

[David Hallas]

hallas created this revision.
hallas added reviewers: Frameworks, elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fix crash while moving files. The backtrace points towards the KJob
  being deleted after emitting the result signal causing the subsequent
  call to isAutoDelete to crash. Instead simply call isAutoDelete and
  potentially deleteLater prior to emitting the result signal.
  
  BUG: 368287

TEST PLAN
  I haven't been able to reproduce the issue so this commit should be
  seen as a test commit to verify if this is indeed the root cause.

REPOSITORY
  R244 KCoreAddons

BRANCH
  fix_crash_on_while_moving_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19170

AFFECTED FILES
  src/lib/jobs/kjob.cpp

To: hallas, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190219/cc41abd1/attachment.html>