D19109: [Extractor] Add metadata to properties

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Feb 18 00:05:20 GMT 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This adds extractor metadata in a backwards and forward compatible way.
  
  There are several use cases for this metadata:
  
  - Delayed loading of extractor plugins - currently, all extractors are loaded and and initialized when an ExtractorCollection is created.
  - Versioning information - e.g. Baloo would benefit from versioning information, to reindex affected files after an extractor has been updated.
  
  Although it would be possible to extend the extractor plugin interface
  with a method for each relevant property, it would require a bump of
  the plugin inteface version each time the interface is extended.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  extractor_properties

REVISION DETAIL
  https://phabricator.kde.org/D19109

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/extractorcollectiontest.cpp
  src/extractor.cpp
  src/extractor.h
  src/extractor_p.h
  src/extractorcollection.cpp
  src/extractorcollection.h
  src/extractors/CMakeLists.txt
  src/extractors/epubextractor.h
  src/extractors/epubextractor.json
  src/extractors/exiv2extractor.h
  src/extractors/exiv2extractor.json.in
  src/extractors/ffmpegextractor.h
  src/extractors/ffmpegextractor.json
  src/extractors/mobiextractor.h
  src/extractors/mobiextractor.json
  src/extractors/odfextractor.h
  src/extractors/odfextractor.json
  src/extractors/office2007extractor.h
  src/extractors/office2007extractor.json
  src/extractors/officeextractor.h
  src/extractors/officeextractor.json
  src/extractors/plaintextextractor.h
  src/extractors/plaintextextractor.json
  src/extractors/poextractor.h
  src/extractors/poextractor.json
  src/extractors/popplerextractor.h
  src/extractors/popplerextractor.json
  src/extractors/postscriptdscextractor.h
  src/extractors/postscriptdscextractor.json
  src/extractors/taglibextractor.h
  src/extractors/taglibextractor.json
  src/extractors/xmlextractor.h
  src/extractors/xmlextractor.json

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190218/494f5747/attachment.html>


More information about the Kde-frameworks-devel mailing list