D19107: Write valid UTF8 characters without escaping.
Jos van den Oever
noreply at phabricator.kde.org
Sun Feb 17 22:40:20 GMT 2019
vandenoever created this revision.
vandenoever added reviewers: dfaure, arichardson, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.
REVISION SUMMARY
commit 6a18528 <https://phabricator.kde.org/R237:6a185285ae44ed182dbab9206b9092f78c7d3714> introduced escaping of bytes >= 127 to ensure that
KConfig files are valid UTF8.
The simplistic approach with a cutoff results in many escaped bytes
where it is not required. Especially non-western configuration files
would have many escapes.
This commit fixes that by only escaping bytes that are not valid UTF8.
TEST PLAN
ninja && ninja test
REPOSITORY
R237 KConfig
BRANCH
utf8
REVISION DETAIL
https://phabricator.kde.org/D19107
AFFECTED FILES
autotests/kconfigtest.cpp
autotests/kconfigtest.h
src/core/kconfigini.cpp
To: vandenoever, dfaure, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190217/fee71f06/attachment.html>
More information about the Kde-frameworks-devel
mailing list