D19099: Add a test for ffmpeg extractor

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Feb 17 20:18:21 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> ffmpegextractortest.cpp:45
> +
> +    QCOMPARE(result.properties().value(Title).toString(), QStringLiteral("Title"));
> +    QCOMPARE(result.properties().value(Copyright).toString(), QStringLiteral("Copyright"));

I find it somewhat difficult to grasp `Title` is KFileMetaData::Property::Title. 
You can use something like:

  namespace KFMProp = KFileMetaData::Property;
  ...
  ... value(KFMProp::Title).toString()

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19099

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190217/642bc4f0/attachment.html>


More information about the Kde-frameworks-devel mailing list