D19007: Wait for DBus Reply Before Performing Computations

David Narváez noreply at phabricator.kde.org
Thu Feb 14 16:30:45 GMT 2019


narvaez created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
narvaez requested review of this revision.

REVISION SUMMARY
  If the scheduler has not replied by the time the batch size is used, the
  default value is 0 and the mod operation results in a Floating Point
  Exception.
  
  I argue similar precautions are not needed for the call to
  m_scheduler->getRemainingTime() in updateRemainingTime because the
  default value of 0 will just lead to a confusing duration string but not
  a crash.

REPOSITORY
  R293 Baloo

BRANCH
  newFile_crash

REVISION DETAIL
  https://phabricator.kde.org/D19007

AFFECTED FILES
  src/qml/experimental/monitor.cpp

To: narvaez
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190214/86158d61/attachment.html>


More information about the Kde-frameworks-devel mailing list