D18940: Add battery icons

Noah Davis noreply at phabricator.kde.org
Wed Feb 13 09:19:45 GMT 2019


ndavis added a comment.


  In D18940#411317 <https://phabricator.kde.org/D18940#411317>, @broulik wrote:
  
  > In D18940#411316 <https://phabricator.kde.org/D18940#411316>, @ndavis wrote:
  >
  > > Won't 3rd party themes contain their own icons?
  >
  >
  > Sure but in the style of a Plasma battery.svgz, so if we change the `BatteryIcon` to use icon theme instead of Plasma theme icons (which none of the other tray icons do, btw) we'll effectively break third party themes.
  
  
  Does a plasmoid need to be told to get the icons from the Plasma theme? Or will it fetch the icon from the icon theme if it does not exist in the plasma theme?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190213/651b1f5a/attachment.html>


More information about the Kde-frameworks-devel mailing list