D18957: Use natural sorting in ActivityModel
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Feb 12 18:18:06 GMT 2019
apol added inline comments.
INLINE COMMENTS
> activitymodel.h:132
> struct InfoPtrComparator {
> bool operator() (const InfoPtr& left, const InfoPtr& right) const
> {
Do you think it would be possible to store the collator elsewhere?
Re-creating it is a bit expensive to be doing it nlogn times per sort (not that it won't work).
We don't support changing the application language at runtime (env vars don't change at runtime), so it shouldn't be a big deal (it could even be a static variable).
REPOSITORY
R6 KActivities
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18957
To: davidedmundson, #plasma, ngraham
Cc: apol, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/da76cbe4/attachment.html>
More information about the Kde-frameworks-devel
mailing list