D18957: Use natural sorting in ActivityModel

David Edmundson noreply at phabricator.kde.org
Tue Feb 12 12:55:07 GMT 2019


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  ActivityModel sorts internally.
  It currently does a non-locale or number aware sort on user-facing
  strings.
  
  This patches uses QCollator.
  
  This changes the order in the KCM.
  
  It doesn't affect the order in the activity switcher as that has it's
  own sorting proxy on top handling last used time.
  
  It doesn't quite fix the issue in the bug report as PagerModel mixes
  sources.
  
  CCBUG: 404149

TEST PLAN
  Set activities named
  "10.asdf"
  "1.foo"
  "2.bar"
  
  KCM now shows them in the order 1,2,10

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18957

AFFECTED FILES
  src/imports/activitymodel.h
  src/lib/activitiesmodel_p.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/37c58452/attachment.html>


More information about the Kde-frameworks-devel mailing list