D18950: KCompressionDevice: reset error in open() to allow reuse of object

Matthias Gerstner noreply at phabricator.kde.org
Tue Feb 12 11:37:26 GMT 2019


mgerstner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mgerstner requested review of this revision.

REVISION SUMMARY
  Previously is was not possible to reuse a `KCompressionDevice` object
  after a call to `open()` failed and `propagateErrorCode()` was called. A
  subsequent `open()` would work but a later `close()` will fail, because
  the older errorCode is still set.
  
  By resetting the error code before doing an `open()` this situation is
  avoided and reuse of objects becomes possible.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D18950

AFFECTED FILES
  src/kcompressiondevice.cpp

To: mgerstner
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/8112cb29/attachment.html>


More information about the Kde-frameworks-devel mailing list