D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  looks almost good to me, can someone else please crosscheck?

INLINE COMMENTS

> documenturldb.h:140
> +                        qWarning() << "DocumentUrlDB::del"
> +                                          << "This folder still has sub-files in its cache. It cannot be deleted";
> +                    }

indentation

> mtimedb.cpp:110
>          rc = mdb_cursor_get(cursor, &key, &val, MDB_NEXT_DUP);
> -        if (rc == MDB_NOTFOUND) {
> +        if (rc) {
> +            qCDebug(ENGINE) << "MTimeDB::get (loop)" << mtime << mdb_strerror(rc);

`if  (rc != MDB_NOTFOUND)` for the message

> bruns wrote in postingdb.cpp:232
> not done ... you have to always `mdb_cursor_close`
> 
> Also, MDB_NOTFOUND is not an error here.

For the debug message, level warning is sufficient ;-)

> transaction.cpp:304
> +    if (rc) {
> +        qCDebug(ENGINE) << "Transaction::commit" << mdb_strerror(rc);
> +    }

This should also be a warning IMHO

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190210/947c1b99/attachment-0001.html>