D18891: Avoid leaking a QObject in ExternalExtractor

Dominik Haumann noreply at phabricator.kde.org
Sun Feb 10 08:30:56 GMT 2019


dhaumann added a comment.


  ThT looks reasonable, if ExtractorPlugin even has `QObject * parent = nullptr` I'd even remove nullptr as well.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18891

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190210/b7960eb6/attachment.html>


More information about the Kde-frameworks-devel mailing list