D18883: Add PDF thumbnailer

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> pdfcreator.cpp:23
> +
> +#include <QFile>
> +#include <QImage>

the QFile include is no more needed now

> broulik wrote in pdfcreator.cpp:45-46
> I can't. The `renderToImage` can only be told a resolution or part of the page to render, to render downscaled into a certain box.
> 
> The `ThumbnailJob` downscales the image when it exceeds the requested size, so doing any manual downscaling (other than already getting the correct size which we can't) here is superfluous.

Sure you can: see what okular does, for example, as it requests pixmaps of precise sizes.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190209/b333277d/attachment.html>