D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> documentdatadb.cpp:42
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::create" << mdb_strerror(rc);
> +        return 0;

Warning

> documentdatadb.cpp:54
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::open" << mdb_strerror(rc);
>          return 0;

warning

> documentdatadb.cpp:76
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::put" << mdb_strerror(rc);
> +    }

warning

> documentdatadb.cpp:90
>      int rc = mdb_get(m_txn, m_dbi, &key, &val);
> -    if (rc == MDB_NOTFOUND) {
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::get" << docId << mdb_strerror(rc);

please keep MDB_NOTFOUND as "ok" here, any other return code != 0 -> qCWarning

> documentdatadb.cpp:107
>      int rc = mdb_del(m_txn, m_dbi, &key, nullptr);
> -    if (rc == MDB_NOTFOUND) {
> -        return;
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::del" << docId << mdb_strerror(rc);

see get

> documentdatadb.cpp:123
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDataDB::contains" << docId << mdb_strerror(rc);
>          return false;

see get

> documentdb.cpp:44
> +    if (rc) {
> +        qCDebug(ENGINE) << "DocumentDB::create" << name << mdb_strerror(rc);
> +        return 0;

same rules for warning/debug as in documentdatadb

> postingdb.cpp:141
>      }
> -    Q_ASSERT_X(rc == 0, "PostingDB::fetchTermsStartingWith", mdb_strerror(rc));
> +    qCDebug(ENGINE) << "PostingDB::fetchTermsStartingWith" << mdb_strerror(rc);
>  

if (rc != MDB_NOTFOUND) ...

> postingdb.cpp:232
> +        qCDebug(ENGINE) << "PostingDB::regexpIter" << mdb_strerror(rc);
> +        return nullptr;
>      }

//critical - You are leaking the cursor now//

> transaction.cpp:283
> +    if (!m_writeTrans) {
> +        qCDebug(ENGINE) << "m_writeTrans is null";
> +        return;

warning

> fileindexscheduler.cpp:186
>      if (isOnBattery && m_indexerState == ContentIndexing) {
> -        qDebug() << "On battery stopping content indexer";
> +        qCDebug(BALOO) << "On battery stopping content indexer";
>          m_contentIndexer->quit();

add a ", " after battery

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190209/a058ecb7/attachment-0001.html>