D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)
Stefan Brüns
noreply at phabricator.kde.org
Sat Feb 9 15:01:43 GMT 2019
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
There is no need to delete and create a new Private on assignment, it is
sufficient to reassign its members.
File::load(url) resets the url, afterwards he old corresponding property
map is no longer valid, clear it.
TEST PLAN
ctest
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18877
AFFECTED FILES
src/lib/file.cpp
To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190209/39cf3381/attachment.html>
More information about the Kde-frameworks-devel
mailing list