D18829: [balooctl] Normalize include/exclude pathes before using it for the config

Nathaniel Graham noreply at phabricator.kde.org
Fri Feb 8 18:36:06 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> configcommand.cpp:43
> +{
> +    while (path.endsWith(QLatin1Char('/'))) {
> +        path.chop(1);

Does this need to be a `while`? Why not a regular old `if`? Are you trying to handle the case where it ends with multiple trailing slashes?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190208/ba4192d4/attachment.html>


More information about the Kde-frameworks-devel mailing list