D18825: Replace recursive isDirHidden with iterative one, allow const argument

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Feb 7 19:17:11 GMT 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The non-unix implementation modifies its QDir argument to walk up the
  tree. Create a copy instead.
  The copy cost is amortized by no longer having to reset the dir in the
  calling code, for the unix-code it is a net win.

REPOSITORY
  R293 Baloo

BRANCH
  submit2

REVISION DETAIL
  https://phabricator.kde.org/D18825

AFFECTED FILES
  src/file/fileindexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190207/b3b8155a/attachment.html>


More information about the Kde-frameworks-devel mailing list