D18813: Filter out invalid content in lists
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Thu Feb 7 13:54:27 GMT 2019
leinir created this revision.
leinir added a reviewer: KNewStuff.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
Prior to this change, if the ocs server being queried returned a list of entries containing invalid entries (such as happened a few days ago for the otherwise empty Akonadi email providers category), the listing function would faithfully return that list of entries verbatim, which led consumers of that list to insist there were more entries to fetch, and then try again, and again, and again. With this patch, only valid entries get forwarded as results to the consumers (be they knewstuff's own dialogues, or others, such as Discover or Peruse).
This change is in KNewStuff rather than Attica, because Attica by design does not apply heuristics of any sort to its functions. That, again by design, is what KNewStuff is for.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D18813
AFFECTED FILES
src/attica/atticaprovider.cpp
To: leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190207/84f61820/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list