D18776: Make sure only directories are added to the inotify watcher

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Although watchFolder is only called for directories, there is a small
  time frame where the just added directory has been deleted and a file
  with the same path has been created. This race condition can be avoided
  by adding the KInotify::FlagOnlyDir filter flag.
  
  This has been documented also in e.g. https://lwn.net/Articles/605128/.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18776

AFFECTED FILES
  src/file/filewatch.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190206/a3bd0ef2/attachment-0001.html>