D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:70
> When you make this
> `void writeGenericProperties(Taglib::File *file, const PropertyMap &newProperties)`, you can do `file->properties(); {/* merge */}; file->setProperties(...);` here, saving most of the duplicate code below.
> 
> dito for the specializations in D18604 <https://phabricator.kde.org/D18604>, just pass in `Taglib::File*`, and call `auto tags = dynamic_cast<FooTag*>(file->tag());` there.

That will then require to load and write the property map twice when properties only specific to some tagging formats need to be written, see e.g. Ape and Vorbis tags in D18604 <https://phabricator.kde.org/D18604>. I would like to avoid this.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/5a99cf69/attachment.html>